Skip to content

feat: add C implementation for stats/base/dists/chisquare/mode #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 19, 2025
Merged

feat: add C implementation for stats/base/dists/chisquare/mode #4002

merged 5 commits into from
Jan 19, 2025

Conversation

@vivekmaurya001
Copy link
Contributor

Resolves #3507.

Description

  • adds C implementation for @stdlib/stats/base/dists/chisquare/mode along with relevant tests, benchmarks and examples

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 17, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 17, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/chisquare/mode $\color{green}162/162$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}162/162$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter self-requested a review January 19, 2025 03:42
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 19, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 19, 2025
@Planeshifter
chore: apply suggestions from code review
877bdc2 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vivekmaurya001!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 19, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 19, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/chisquare/mode`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4002
Closes: https://github.com/stdlib-js/stdlib/issues/3507

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 292c21e into stdlib-js:develop Jan 19, 2025
28 checks passed
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@vivekmaurya001 @Planeshifter
@stdlib-bot @Neerajpathak07
feat: add C implementation for stats/base/dists/chisquare/mode
9d79c0f 
PR-URL: stdlib-js#4002
Closes: stdlib-js#3507

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Vinit-Pandit pushed a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025
@vivekmaurya001 @Planeshifter
@stdlib-bot @Vinit-Pandit
feat: add C implementation for stats/base/dists/chisquare/mode
2ff76b8 
PR-URL: stdlib-js#4002
Closes: stdlib-js#3507

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@vivekmaurya001 @Planeshifter
@stdlib-bot @ShabiShett07
feat: add C implementation for stats/base/dists/chisquare/mode
044fad1 
PR-URL: stdlib-js#4002
Closes: stdlib-js#3507

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/chisquare/mode

3 participants

@vivekmaurya001 @stdlib-bot @Planeshifter